Skip to content

Add a WindowGroup for each appwindow #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

Add a WindowGroup for each appwindow #1556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion crates/rnote-ui/src/app/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use crate::{
workspacebrowser::RnWorkspacesBar, workspacebrowser::workspacesbar::RnWorkspaceRow,
};
use adw::subclass::prelude::AdwApplicationImpl;
use gtk4::{gio, glib, glib::clone, prelude::*, subclass::prelude::*};
use gtk4::{WindowGroup, gio, glib, glib::clone, prelude::*, subclass::prelude::*};

mod imp {
use super::*;
Expand Down Expand Up @@ -133,6 +133,13 @@ mod imp {
pub(crate) fn new_appwindow_init_show(&self, input_file: Option<gio::File>) {
let appwindow = RnAppWindow::new(self.obj().upcast_ref::<gtk4::Application>());
appwindow.init();
// create a window group for each app window
// to make modals only impact the current app
// window.
// See issue #1461
let window_group = WindowGroup::new();
window_group.add_window(&appwindow);

appwindow.present();

// Loading in input file in the first tab, if Some
Expand Down