Add a WindowGroup for each appwindow
#1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restricts the `modal` nature of dialogs to each `appwindow` instead of being applied to all instances of opened window. This would result in weird behavior (if a modal is opened in one instance, a new freshly launched instance would have all inputs frozen) Fixes flxzt#1461
|
Now tested on linux (both a local meson build and the flatpak with a nightly) and windows (on the exe produced by the windows release CI) |
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restricts the
modalnature of dialogs to eachappwindowinstead of being applied to all instances of opened rnote windows. This would result in weird behavior (if a modal is opened in one instance, a new freshly launched instance would have all inputs frozen)Fixes #1461