Skip to content

fix RECORD_AUDIO permission on Android when there is no permission #10424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix RECORD_AUDIO permission on Android when there is no permission #10424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...id_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,16 @@ public PendingRecording asPersistentRecording(PendingRecording pigeonInstance) {

@NonNull
@Override
public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {
if (!initialMuted
&& ContextCompat.checkSelfPermission(
getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
== PackageManager.PERMISSION_GRANTED) {
return pigeonInstance.withAudioEnabled(false);
public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {
boolean hasPermission = ContextCompat.checkSelfPermission(
getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
== PackageManager.PERMISSION_GRANTED;

if (hasPermission) {
return pigeonInstance.withAudioEnabled(initialMuted);
}

return pigeonInstance.withAudioEnabled(true);
return pigeonInstance;
}

@NonNull
Expand Down