Skip to content

Conversation

@agrapine
Copy link

Allows to record video without audio when we init the CameraController with enableAudio=false

 final controller = CameraController(
        camera.first,
        ResolutionPreset.high,
        enableAudio: false,
      );

@agrapine agrapine requested a review from camsim99 as a code owner November 14, 2025 09:36
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix how audio recording is handled when permissions are missing or audio is disabled. While the intent is correct, the implementation contains a critical logical error that would mute audio when it should be enabled. Additionally, the corresponding unit tests have not been updated to reflect the new logic, which would cause them to fail. I've provided a detailed review comment on the withAudioEnabled method with a suggested fix and a reference to the testing guidelines.

@agrapine agrapine force-pushed the fix/record_audio_permission branch 2 times, most recently from 1511863 to 5e57600 Compare November 14, 2025 10:06
@agrapine agrapine force-pushed the fix/record_audio_permission branch from 5e57600 to e443aed Compare November 14, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant