Skip to content

Conversation

DiamonDinoia
Copy link
Collaborator

No description provided.

@magland
Copy link
Collaborator

magland commented Oct 2, 2025

@DiamonDinoia It's possible that these changes slowed down the decode. This is from the CI artifact for this PR:
benchmark2_decode_rate

Compared with the current timings:

image

Whereas for encode, things seem to have gotten better. Here's this PR:
benchmark2_encode_rate

Compared with current encode:
image

Could you try some benchmarks on your end, please?

@DiamonDinoia
Copy link
Collaborator Author

Sure, I will have a look

@DiamonDinoia DiamonDinoia force-pushed the modernize branch 2 times, most recently from fc4d506 to 47885fd Compare October 2, 2025 20:50
@DiamonDinoia
Copy link
Collaborator Author

I am not sure why there is a slowdown. As I don't see the same behavior locally. Maybe a difference in the stdlib or compiler version?

I propose we go through all the changes I have planned and if the slowdown persists we can revert the changes here.

@DiamonDinoia
Copy link
Collaborator Author

Also, I think the faster results might be a lucky draw. Even blosc is over 5GB/s in master but 4.8GB/s in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants