Write Firebase Token to Auth instance during exchange_token API #9060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansisampat
requested review from
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
NhienLam and
a team
as code owners
|
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
pashanka
approved these changes
May 26, 2025
Size Analysis Report 1Affected Products
Test Logs |
NhienLam
reviewed
May 27, 2025
| accessToken: string; | ||
| expiresIn?: string; | ||
| // The time when the access token expires. |
There was a problem hiding this comment.
Yes, The expiresIn is in seconds.
| @@ -455,6 +457,14 @@ export class AuthImpl implements AuthInternal, _FirebaseService { | |||
| }); | |||
| } | |||
|
|
|||
| async _updateFirebaseToken( | |||
| firebaseToken: FirebaseToken | null | |||
There was a problem hiding this comment.
Do we have to accept null here?
There was a problem hiding this comment.
Ah i just saw your new changes in https://github.com/firebase/firebase-js-sdk/pull/9061/files. If this.firebaseToken can be null, then this makes sense.
There was a problem hiding this comment.
Correct. We are updating FirebaseToken with null after token expiry.
| export interface FirebaseToken { | ||
| // The firebase access token (JWT signed by Firebase Auth). | ||
| readonly token: string; | ||
| // The time when the access token expires. |
There was a problem hiding this comment.
is this in seconds? Asking because I see you're * 1000 in the above change.
There was a problem hiding this comment.
Looks like it's a timestamp (in milliseconds since epoch)? Could we clarify that in a comment to be more clear? Thanks!
NhienLam
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Testing