Implement getToken method for Regional Auth Interop #9061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansisampat
requested review from
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
NhienLam and
a team
as code owners
|
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
pashanka
reviewed
May 26, 2025
| @@ -51,6 +52,27 @@ export class AuthInterop implements FirebaseAuthInternal { | |||
| return { accessToken }; | |||
| } | |||
|
|
|||
| async getFirebaseToken(): Promise<{ accessToken: string } | null> { | |||
There was a problem hiding this comment.
Shouldn't we use the existing getToken method instead of new? If we create new, then wouldn't the existing product logic have to make changes?
There was a problem hiding this comment.
In that case we would have to force that getToken method should have forceRefresh as false if regional auth is initialized.
There was a problem hiding this comment.
Yes, that would be the case as refreshToken is not supported. Alternatively we can log a warning message and ignore the field for now, but i would prefer throwing error as it makes it more clear.
mansisampat
changed the title
pashanka
reviewed
May 27, 2025
| @@ -85,11 +95,35 @@ export class AuthInterop implements FirebaseAuthInternal { | |||
| ); | |||
| } | |||
|
|
|||
| private assertRegionalAuthConfigured(): void { | |||
| _assert(this.auth.tenantConfig, AuthErrorCode.OPERATION_NOT_ALLOWED); | |||
| } | |||
There was a problem hiding this comment.
Is this required with new changes?
There was a problem hiding this comment.
Removed unused methods.
pashanka
approved these changes
May 27, 2025
NhienLam
reviewed
May 27, 2025
NhienLam
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Testing