Skip to content

firestore(test): AggregationTest.java: update tests for now-supported enterprise aggregations in emulator #7853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dconeybe wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −41
Draft

firestore(test): AggregationTest.java: update tests for now-supported enterprise aggregations in emulator #7853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 11 additions & 41 deletions firebase-firestore/src/androidTest/java/com/google/firebase/firestore/AggregationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,26 +540,12 @@ public void testPerformsSumThatOverflowsMaxLong() {
"b", map("author", "authorB", "title", "titleB", "rating", Long.MAX_VALUE));
CollectionReference collection = testCollectionWithDocs(testDocs);

switch (getBackendEdition()) {
case STANDARD:
{
AggregateQuerySnapshot snapshot =
waitFor(collection.aggregate(sum("rating")).get(AggregateSource.SERVER));

Object sum = snapshot.get(sum("rating"));
assertTrue(sum instanceof Double);
assertEquals(sum, (double) Long.MAX_VALUE + (double) Long.MAX_VALUE);
break;
}
case ENTERPRISE:
{
assertThrows(
RuntimeException.class,
() -> {
waitFor(collection.aggregate(sum("rating")).get(AggregateSource.SERVER));
});
}
}
AggregateQuerySnapshot snapshot =
waitFor(collection.aggregate(sum("rating")).get(AggregateSource.SERVER));

Object sum = snapshot.get(sum("rating"));
assertTrue(sum instanceof Double);
assertEquals(sum, (double) Long.MAX_VALUE + (double) Long.MAX_VALUE);
}

@Test
Expand Down Expand Up @@ -589,20 +575,10 @@ public void testPerformsSumThatIsNegative() {
"d", map("author", "authorD", "title", "titleD", "rating", -10000));
CollectionReference collection = testCollectionWithDocs(testDocs);

switch (getBackendEdition()) {
case STANDARD:
AggregateQuerySnapshot snapshot =
waitFor(collection.aggregate(sum("rating")).get(AggregateSource.SERVER));

assertEquals(snapshot.get(sum("rating")), -10101L);
break;
case ENTERPRISE:
assertThrows(
RuntimeException.class,
() -> {
waitFor(collection.aggregate(sum("rating")).get(AggregateSource.SERVER));
});
}
AggregateQuerySnapshot snapshot =
waitFor(collection.aggregate(sum("rating")).get(AggregateSource.SERVER));

assertEquals(snapshot.get(sum("rating")), -10101L);
}

@Test
Expand Down Expand Up @@ -675,13 +651,7 @@ public void testPerformsSumOverResultSetOfZeroDocuments() {
.aggregate(sum("pages"))
.get(AggregateSource.SERVER));

switch (getBackendEdition()) {
case STANDARD:
assertEquals(snapshot.get(sum("pages")), 0L);
break;
case ENTERPRISE:
assertNull(snapshot.get(sum("pages")));
}
assertEquals(snapshot.get(sum("pages")), 0L);
}

@Test
Expand Down
Loading