Skip to content

firestore(test): AggregationTest.java: update tests for now-supported enterprise aggregations in emulator#7853

Draft
dconeybe wants to merge 1 commit intomainfrom
dconeybe/firestore/EnterpriseEmuTestFixes
Draft

firestore(test): AggregationTest.java: update tests for now-supported enterprise aggregations in emulator#7853
dconeybe wants to merge 1 commit intomainfrom
dconeybe/firestore/EnterpriseEmuTestFixes

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Feb 27, 2026

This PR updates AggregationTest.java to reflect that the Firestore emulator now supports aggregations that were previously only available in the standard edition. The tests have been updated to remove the conditional logic that differentiated between backend editions, and now assert the same behavior for all editions.

Highlights

  • Updated AggregationTest.java to reflect new emulator capabilities.
  • Removed conditional logic for backend editions in aggregation tests.
  • Tests for sum aggregations with overflow, negative numbers, and zero documents are now unified.
Changelog
  • AggregationTest.java
    • Removed backend edition checks for testPerformsSumThatOverflowsMaxLong.
    • Removed backend edition checks for testPerformsSumThatIsNegative.
    • Removed backend edition checks for testPerformsSumOverResultSetOfZeroDocuments.

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant