Add Ruby 3.4 support #133
Merged
Add Ruby 3.4 support #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.4 is removing the `base64` default gem to [became bundled](https://rubyreferences.github.io/rubychanges/3.4.html#default-gems-that-became-bundled) Making the current webmock (v3.16.2) gem incompatible because it has a dependency on the `base64` gem, to fix it we are bumping webmock to v3.20.0 which [removed the `base64`](bblimke/webmock#1046) dependency. > [!NOTE] > As an alternative solution, we can leave the current `webmock` version untoched and add the `base64` gem as a dependency.
JuanVqz
force-pushed
the
add-ruby-3-4-support
branch
from
249076e to
816e5b6
Compare
JuanVqz
commented
Feb 4, 2025
next_rails.gemspec
Outdated
| @@ -13,7 +13,7 @@ Gem::Specification.new do |spec| | |||
| spec.homepage = "https://github.com/fastruby/next_rails" | |||
| spec.license = "MIT" | |||
|
|
|||
| spec.required_ruby_version = ">= 2.0" | |||
| spec.required_ruby_version = ">= 2.0", "< 3.5" | |||
There was a problem hiding this comment.
I thought it would be ideal to block supported Ruby versions to make sure users can rely on it, happy to remove it if you don't find it valuable tho
etagwerker
requested changes
Feb 6, 2025
There was a problem hiding this comment.
@JuanVqz I like these changes but I'd like to skip the change limiting the required ruby version.
JuanVqz
commented
Feb 7, 2025
etagwerker
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ruby 3.4 is removing the
base64default gem to became bundledMaking the current webmock (v3.16.2) gem incompatible because it has a dependency on the
base64gem,to fix it we are bumping webmock to v3.20.0 which removed the
base64dependency.Note
As an alternative solution, we can leave the current
webmockversion untochedand add the
base64gem as a dependency.Motivation and Context
Increase the compatibility of the project with the latest Ruby versions.
How Has This Been Tested?
Screenshots:
I will abide by the code of conduct