Skip to content

Commit 249076e

Browse files
committed
Add Ruby 3.4 support
Ruby 3.4 is removing the `base64` default gem to [became bundled](https://rubyreferences.github.io/rubychanges/3.4.html#default-gems-that-became-bundled) Making the current webmock (v3.16.2) gem incompatible because it has a dependency on the `base64` gem, to fix it we are bumping webmock to v3.20.0 which [removed the `base64`](bblimke/webmock#1046) dependency. As an alternative solution, we can leave the current `webmock` version untoched and add the `base64` gem as a dependency. Given this message: `limited on purpose, new versions don't work with old rubies` we might lost support of some old rubies.
1 parent 05fcfe1 commit 249076e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
ruby-version: ["3.3", "3.2", "3.1", "3.0", "2.7", "2.6"]
16+
ruby-version: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7", "2.6"]
1717

1818
steps:
1919
- uses: actions/checkout@v2

next_rails.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
1313
spec.homepage = "https://github.com/fastruby/next_rails"
1414
spec.license = "MIT"
1515

16-
spec.required_ruby_version = ">= 2.0"
16+
spec.required_ruby_version = ">= 2.0", "< 3.5"
1717

1818
spec.files = `git ls-files -z`.split("\x0").reject do |f|
1919
f.match(%r{^(test|spec|features)/})
@@ -30,5 +30,5 @@ Gem::Specification.new do |spec|
3030
spec.add_development_dependency "timecop", "~> 0.9.1"
3131
spec.add_development_dependency "byebug"
3232
spec.add_development_dependency "rexml", "3.3.8" # limited on purpose, new versions don't work with old rubies
33-
spec.add_development_dependency "webmock", "3.16.2" # limited on purpose, new versions don't work with old rubies
33+
spec.add_development_dependency "webmock", "3.20.0"
3434
end

0 commit comments

Comments
 (0)