Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STATS-2239]: Update Fastly-exporter with new fields (and remove vcl_on_compute) #189

Merged
merged 6 commits into from
Mar 13, 2025

Conversation

drrev
Copy link
Contributor

@drrev drrev commented Mar 12, 2025

Summary

This PR makes the following changes to synchronize with the latest schema:

  • RT:
    • Added:
      • bot_challenges_verification_api_duplicate_count
      • bot_challenges_verification_api_expired_count
      • bot_challenges_verification_api_failure_count
      • bot_challenges_verification_api_success_count
      • compute_cache_operations_count
      • ddos_protection_requests_allow_count
      • ddos_protection_requests_detect_count
      • ddos_protection_requests_mitigate_count
      • object_storage_class_a_operations_count
      • object_storage_class_b_operations_count
      • request_collapse_unusable_count
      • request_collapse_usable_count
      • request_denied_get_head_body
      • status_530
    • Removed:
      • vcl_on_compute_edge_hit_requests_total
      • vcl_on_compute_edge_miss_requests_total
      • vcl_on_compute_error_requests_total
      • vcl_on_compute_hit_requests_total
      • vcl_on_compute_miss_requests_total
      • vcl_on_compute_pass_requests_total
      • vcl_on_compute_synth_requests_total
  • Origins:
    • Added:
      • compute_status_530
      • status_530
      • waf_status_530
  • Domains:
    • Added:
      • origin_status_530
      • status_530

Known Issues

  • No API doc exists for the new bot_challenges_* metrics, so the associated help is empty.

@drrev drrev requested a review from leklund March 12, 2025 16:48
@drrev drrev merged commit 04d5a59 into main Mar 13, 2025
14 checks passed
@drrev drrev deleted the rreeves/add-new-fields branch March 13, 2025 15:32
@SuperQ
Copy link
Contributor

SuperQ commented Mar 13, 2025

FYI, _count is not a valid metric suffix for counter metrics. They should end in _total.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants