Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change suffixes from _count to _total #191

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

drrev
Copy link
Contributor

@drrev drrev commented Mar 13, 2025

Summary

This PR addresses a naming issue with RT metrics introduced in #189:

Old New
bot_challenges_verification_api_duplicate_count bot_challenges_verification_api_duplicate_total
bot_challenges_verification_api_expired_count bot_challenges_verification_api_expired_total
bot_challenges_verification_api_failure_count bot_challenges_verification_api_failure_total
bot_challenges_verification_api_success_count bot_challenges_verification_api_success_total
compute_cache_operations_count compute_cache_operations_total
ddos_protection_requests_allow_count ddos_protection_requests_allow_total
ddos_protection_requests_detect_count ddos_protection_requests_detect_total
ddos_protection_requests_mitigate_count ddos_protection_requests_mitigate_total
object_storage_class_a_operations_count object_storage_class_a_operations_total
object_storage_class_b_operations_count object_storage_class_b_operations_total
request_collapse_unusable_count request_collapse_unusable_total
request_collapse_usable_count request_collapse_usable_total

@drrev drrev requested a review from leklund March 13, 2025 17:08
@drrev drrev merged commit 2ce3c8f into main Mar 13, 2025
14 checks passed
@drrev drrev deleted the bugfixes/fix-suffix-count-total branch March 13, 2025 18:35
@SuperQ
Copy link
Contributor

SuperQ commented Mar 13, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants