Skip to content

Conversation

nauanbek
Copy link
Contributor

@nauanbek nauanbek commented Feb 4, 2025

BEFORE: user_in = UserCreate(email=email, password=password, disabled=True)
AFTER: Use proper is_active field

@alejsdev alejsdev changed the title Use proper is_active field in test_user.py ♻️ Use proper is_active field in test_user.py Feb 10, 2025
@YuriiMotov YuriiMotov changed the title ♻️ Use proper is_active field in test_user.py ♻️ Use proper is_active field in test_user.py Sep 2, 2025
Copy link

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Previously UserCreate used default value for is_active (True) and test didn't fail because assertion was wrong.

@nauanbek, thanks!

@YuriiMotov YuriiMotov changed the title ♻️ Use proper is_active field in test_user.py ✅ Use proper is_active field in test_user.py Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants