-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Description
First of all, thank you very much for sharing this project. I already learned a lot by building my first API based on this template.
When I looked at the test cases I was wondering about the intention of the following test. I thought it is about creating an inactive user but the UserCreate schema does not accept an attribute disabled
. The respective attribute is is_active
. The logic also does not make sense to me except this test intention is to show that you can not create an inactive user. Otherwise, it should be assert not is_active
. But then the test fails even if you replace the disabled
with is_active
It turns out that CRUDUser.create ignores is_active
.
If it is intended that you can not create an inactive user than the User Schemas should be altered such that the is_active
attribute is not optional for UserCreate.