Skip to content

Commit

Permalink
feat(cli): scale --machine-type (#418)
Browse files Browse the repository at this point in the history
  • Loading branch information
efiop authored Feb 19, 2025
1 parent d192b6d commit fd992cd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
9 changes: 9 additions & 0 deletions projects/fal/src/fal/cli/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ def _scale(args):
and args.min_concurrency is None
and args.request_timeout is None
and args.startup_timeout is None
and args.machine_types is None
):
args.console.log("No parameters for update were provided, ignoring.")
return
Expand All @@ -140,6 +141,7 @@ def _scale(args):
min_concurrency=args.min_concurrency,
request_timeout=args.request_timeout,
startup_timeout=args.startup_timeout,
machine_types=args.machine_types,
)
table = _apps_table([alias_info])

Expand Down Expand Up @@ -188,6 +190,13 @@ def _add_scale_parser(subparsers, parents):
type=int,
help="Startup timeout (seconds).",
)
parser.add_argument(
"--machine-type",
type=str,
action="append",
dest="machine_types",
help="Machine type.",
)
parser.set_defaults(func=_scale)


Expand Down
3 changes: 3 additions & 0 deletions projects/fal/src/fal/sdk.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,9 @@ def update_application(
min_concurrency: int | None = None,
request_timeout: int | None = None,
startup_timeout: int | None = None,
machine_types: list[str] | None = None,
) -> AliasInfo:
print(machine_types)
request = isolate_proto.UpdateApplicationRequest(
application_name=application_name,
keep_alive=keep_alive,
Expand All @@ -591,6 +593,7 @@ def update_application(
min_concurrency=min_concurrency,
request_timeout=request_timeout,
startup_timeout=startup_timeout,
machine_types=machine_types,
)
res: isolate_proto.UpdateApplicationResult = self.stub.UpdateApplication(
request
Expand Down

0 comments on commit fd992cd

Please sign in to comment.