fix(toolkit): use fallback_save_kwargs for object_lifecycle (#423)

* fix(toolkit): use fallback_save_kwargs for object_lifecycle * also multipart
fal-ai · Feb 19, 2025 · d192b6d · d192b6d
1 parent 72688b8
commit d192b6d
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/projects/fal/src/fal/toolkit/file/file.py b/projects/fal/src/fal/toolkit/file/file.py
@@ -156,6 +156,9 @@ def from_bytes(
         save_kwargs.setdefault(
             "object_lifecycle_preference", object_lifecycle_preference
         )
+        fallback_save_kwargs.setdefault(
+            "object_lifecycle_preference", object_lifecycle_preference
+        )
 
         try:
             url = repo.save(fdata, **save_kwargs)
@@ -165,11 +168,7 @@ def from_bytes(
 
             fallback_repo = get_builtin_repository(fallback_repository)
 
-            url = fallback_repo.save(
-                fdata,
-                object_lifecycle_preference=object_lifecycle_preference,
-                **fallback_save_kwargs,
-            )
+            url = fallback_repo.save(fdata, **fallback_save_kwargs)
 
         return cls(
             url=url,
@@ -206,13 +205,20 @@ def from_path(
         object_lifecycle_preference = (
             request_lifecycle_preference(request) or LIFECYCLE_PREFERENCE.get()
         )
+        save_kwargs.setdefault(
+            "object_lifecycle_preference", object_lifecycle_preference
+        )
+        fallback_save_kwargs.setdefault(
+            "object_lifecycle_preference", object_lifecycle_preference
+        )
+
+        save_kwargs.setdefault("multipart", multipart)
+        fallback_save_kwargs.setdefault("multipart", multipart)
 
         try:
             url, data = repo.save_file(
                 file_path,
                 content_type=content_type,
-                multipart=multipart,
-                object_lifecycle_preference=object_lifecycle_preference,
                 **save_kwargs,
             )
         except Exception:
@@ -224,8 +230,6 @@ def from_path(
             url, data = fallback_repo.save_file(
                 file_path,
                 content_type=content_type,
-                multipart=multipart,
-                object_lifecycle_preference=object_lifecycle_preference,
                 **fallback_save_kwargs,
             )