Fix: loading bundle using debug_http_host preferences
#54687
Closed
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
Summary: In facebook#54139 I have removed checking shared preferences for `debug_http_host`. The diff reverts this removal because it is used for changing the bundle source before the app starts. ## Changelog: [ANDROID][FIXED] - revert removal of checking shared preferences for `debug_http_host`. Test Plan: I have run the `rn-tester` app and swapped a default prefs file on Android emulator located in: `/data/data/com.facebook.react.uiapp/shared_prefs/com.facebook.react.uiapp_preferences.xml` with one that had updated port in `debug_http_host` setting to `8082`: ```xml <?xml version='1.0' encoding='utf-8' standalone='yes' ?> <map> <boolean name="fps_debug" value="true" /> <string name="debug_http_host">10.0.2.2:8082</string> <boolean name="inspector_debug" value="true" /> </map> ``` Then, I have run the app and checked if the bundle is loaded from the Metro instance invoked using `yarn start --port 8082`. Differential Revision: D87869540 Pulled By: coado
coado
force-pushed
the
fix-bundle-preferences-loading
branch
from
62eed74 to
056d01b
Compare
Contributor
radon can support RN 83 now thank you! |
cortinico
approved these changes
Nov 26, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #54139 I have removed checking shared preferences for
debug_http_host. The diff reverts this removal because it is used for changing the bundle source before the app starts.Changelog:
[ANDROID][FIXED] - revert removal of checking shared preferences for
debug_http_host.Test Plan:
I have run the
rn-testerapp and swapped a default prefs file on Android emulator located in:/data/data/com.facebook.react.uiapp/shared_prefs/com.facebook.react.uiapp_preferences.xmlwith one that had updated port indebug_http_hostsetting to8082:Then, I have run the app and checked if the bundle is loaded from the Metro instance invoked using
yarn start --port 8082.