Commit 2ac5488
Fix: loading bundle using
Summary:
In #54139 I have removed checking shared preferences for `debug_http_host`. The diff reverts this removal because it is used for changing the bundle source before the app starts.
## Changelog:
[ANDROID][FIXED] - revert removal of checking shared preferences for `debug_http_host`.
Pull Request resolved: #54687
Test Plan:
I have run the `rn-tester` app and swapped a default prefs file on Android emulator located in: `/data/data/com.facebook.react.uiapp/shared_prefs/com.facebook.react.uiapp_preferences.xml` with one that had updated port in `debug_http_host` setting to `8082`:
```xml
<?xml version='1.0' encoding='utf-8' standalone='yes' ?>
<map>
<boolean name="fps_debug" value="true" />
<string name="debug_http_host">10.0.2.2:8082</string>
<boolean name="inspector_debug" value="true" />
</map>
```
Then, I have run the app and checked if the bundle is loaded from the Metro instance invoked using `yarn start --port 8082`.
Reviewed By: cortinico
Differential Revision: D87869540
Pulled By: coado
fbshipit-source-id: 9a76990b097ad7ff24cbbc5202ca935053de23e5debug_http_host preferences (#54687)1 parent f0cbc93 commit 2ac5488
File tree
1 file changed
+13
-0
lines changed- packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection
1 file changed
+13
-0
lines changedLines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| 13 | + | |
| 14 | + | |
11 | 15 | | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| 19 | + | |
| 20 | + | |
15 | 21 | | |
16 | 22 | | |
17 | 23 | | |
| |||
24 | 30 | | |
25 | 31 | | |
26 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
27 | 39 | | |
28 | 40 | | |
29 | 41 | | |
| |||
63 | 75 | | |
64 | 76 | | |
65 | 77 | | |
| 78 | + | |
66 | 79 | | |
67 | 80 | | |
0 commit comments