Skip to content

latest

Pre-release
Pre-release
Compare
Choose a tag to compare
@github-actions github-actions released this 13 Apr 15:18
· 0 commits to c755dc088b5fc15b65f7b5537c34f7a90b228e2c since this release
reduce graph traversal memory, use set not dict

Summary:
A dict has to store an extra 8 bytes `Value` pointer for every entry, whereas a set stores an instance of the zero-length `()` rust type.
Note: this depends on `set` returning keys in the order they are added. The current implementation of `set` in `starlark-rust` is a `SmallMap`, which is the same type a `dict` is built on.

Reviewed By: JakobDegen

Differential Revision: D68671724

fbshipit-source-id: 886d04557591753cc1cdbac13eecdb9f0b180644