latest

Add local_linker_script_flags attribute to prebuilt_cxx_library

Summary: Some `prebuilt_cxx_binary` need to pass in linker scripts if link groups is not used. Link group attributes are not typed right now, so we can't pass in a linker script file as an arg. Add an extra field `local_linker_script_flags` that's only read when not using link groups, this will be removed once link group map migrates to rules.

Reviewed By: milend

Differential Revision: D68723768

fbshipit-source-id: 6980e44dcfd8c5672b109e1634be3720b05f9b22

2025-02-01

use legacy driver when generating index store output

Summary:
The swift-driver enforces output paths are unique, and will fail when producing index store output with:
```
SwiftDriverExecution/MultiJobExecutor.swift:207: Fatal error: multiple producers
for output /dev/null: Compiling ...
```
For now force the legacy driver for index store output.

Reviewed By: drodriguez

Differential Revision: D68978696

fbshipit-source-id: 38c94f3202abbf13cb7cf07758ceab5c63462349

2025-01-15

Add ErrorTags for DiceErrors

Summary: ^ makes it easier to spot DiceErrors when we encounter them

Reviewed By: JakobDegen

Differential Revision: D68188049

fbshipit-source-id: 01ccc029f7deb4529f78e87a0c3926a86695d326

2025-01-02

Collect link groups roots into set instead of list

Summary: This change is required for further diffs where we check each node in roots when traversing graph of linkables. We can do it with `list` too, but `set` is simply more perfromant.

Reviewed By: artempyanykh

Differential Revision: D67389696

fbshipit-source-id: a5ea7ace8693dc98b9c823d4453105a4005d0062

2024-12-16

buck2: explain: switch colors up a bit

Summary: want to show excess cache misses in a different color

Reviewed By: perehonchuk

Differential Revision: D67180041

fbshipit-source-id: 8d64872bd87736f6bad4fccce39835a52905a0da

2024-12-02

fix test_test_artifacts.py::test_remote_artifact_directory_is_not_mat…

2024-11-15

argfiles: Clean up dependency on `canonicalize` and `cwd`

Summary: I was hoping to remove the `canonicalize` call here but that turns out to be a bit hard - but let's at least make the reason it has to be there more explicit, and also not reuse the immediate context for the cwd

Reviewed By: stepancheg

Differential Revision: D65845854

fbshipit-source-id: 11cfd4cf8680a99436727cdc3a20191db484a2e4

2024-11-01

Convert log commands to record InvocationRecord

Summary: Log commands don't have any InvocationRecord generated.  I would like to track details about who/how invokes log commands. Let's ensure they are written to buck2_builds table with no event log option (so scrapped from scribe?).

Reviewed By: iguridi

Differential Revision: D64044944

fbshipit-source-id: d4ec4a9fe3cc12224f8344dea218abe96a49223c

2024-10-15

Refactor derive(Freeze)

Summary:
Use the same parser for `#[freeze]` on struct and on field. Errors with better spans.

For future changes. What we need is something like

```
#[freeze(frozen = ...)]
```

to `derive(Freeze)` when some fields are generic but freeze is identity. Currently it is not possible, because even if bounds is specified, generated code still uses `T::Frozen` for frozen type parameter.

Reviewed By: JakobDegen

Differential Revision: D64337850

fbshipit-source-id: 970c3ade11061b9f3bd4f55baabf78cc076a9f6d

2024-10-01

Include ExecutionPlatformResolutionKey in cfg graph cycle detector.

Summary: ^

Reviewed By: JakobDegen

Differential Revision: D63337541

fbshipit-source-id: 42f53c1c9660cc936fff7111b054c26bd6ecb696