feat: generate sitemap.xml for SEO indexing #1838
+121
−14
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| sitemap: false | ||
| redirect_to: | ||
| - https://github.com/expressjs/expressjs.com/tree/2x | ||
| --- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6,6 +6,7 @@ menu: changelog | ||
| lang: id | ||
| redirect_from: | ||
| - "id/changelog/4x.html" | ||
| sitemap: false | ||
| --- | ||
|
|
||
| # Release changelog | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| --- | ||
| layout: null | ||
| sitemap: false | ||
| --- | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml"> | ||
| {% for lang in site.data.languages %} | ||
| <url> | ||
| {% if lang.code == 'en' %} | ||
| <loc>{{site.url}}</loc> | ||
| {% else %} | ||
| <loc>{{site.url}}/{{ lang.code }}/</loc> | ||
| {% endif %} | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| <xhtml:link rel="alternate" hreflang="x-default" href="{{ site.url }}" /> | ||
| {% for alt_lang in site.data.languages %} | ||
| {% if alt_lang.code == 'en' %} | ||
| <xhtml:link rel="alternate" hreflang="en" href="{{ site.url }}" /> | ||
| {% else %} | ||
| <xhtml:link rel="alternate" hreflang="{{ alt_lang.code }}" href="{{ site.url }}/{{ alt_lang.code }}/" /> | ||
| {% endif %} | ||
| {% endfor %} | ||
| </url> | ||
| {% endfor %} | ||
| {% for page in site.html_pages %} | ||
| {% assign clean_url = page.url | split: '/' | slice: 2, page.url.size | join: '/' %} | ||
| {% if clean_url.size > 0 %} | ||
| {% if page.layout != 404 and page.sitemap != false %} | ||
| <url> | ||
| <loc>{{site.url}}{{ page.url}}</loc> | ||
| <xhtml:link rel="alternate" hreflang="x-default" href="{{ site.url }}/en/{{ clean_url }}" /> | ||
| {% for lang in site.data.languages %} | ||
| <xhtml:link rel="alternate" hreflang="{{ lang.code }}" href="{{ site.url }}/{{ lang.code }}/{{ clean_url }}" /> | ||
| {% endfor %} | ||
| </url> | ||
| {% endif %} | ||
| {% endif %} | ||
| {% endfor %} | ||
| <url> | ||
| <loc>https://expressjs.com/en/changelog/</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| {% for post in site.posts %} | ||
| <url> | ||
| <loc>{{site.url}}{{post.url}}</loc> | ||
| <lastmod>{{ post.date | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| {% endfor %} | ||
| <url> | ||
| <loc>https://nodejs.org/en/</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| <url> | ||
| <loc>https://www.netlify.com/</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
|
Comment on lines
+53
to
+56
There was a problem hiding this comment. I don't think we should add Netlify. I understand the others, as they are part of the foundation, but Netlify is not. And having bots detect Netlify, I don't think that's our priority. There was a problem hiding this comment. yup, may be help them in page ranking. I will remove it. should be add robot.txt to reference sitemap.xml? Jekyll itself doesn’t require a file, but it can be useful for controlling how search engines crawl site. There was a problem hiding this comment. link explains about external link in |
||
| <url> | ||
| <loc>https://openjsf.org/</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| <url> | ||
| <loc>https://terms-of-use.openjsf.org/</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| <url> | ||
| <loc>https://privacy-policy.openjsf.org/</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
ShubhamOulkar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <url> | ||
| <loc>https://github.com/expressjs/express/blob/master/Code-Of-Conduct.md</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| <url> | ||
| <loc>https://trademark-policy.openjsf.org/</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| <url> | ||
| <loc>https://github.com/expressjs/express/security/policy</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| <url> | ||
| <loc>https://github.com/expressjs/express/blob/master/LICENSE</loc> | ||
| <lastmod>{{ site.time | date_to_xmlschema }}</lastmod> | ||
| </url> | ||
| </urlset> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6,6 +6,7 @@ menu: changelog | ||
| lang: th | ||
| redirect_from: | ||
| - "th/changelog/4x.html" | ||
| sitemap: false | ||
| --- | ||
|
|
||
| # Release changelog | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a good practice? We still don't have the option to specify when the file was last modified, something we should add in the future. But as you're proposing, it takes the date the website was built, which I'm not sure is a good practice for Google.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on it should be last modified time. And it is good practice recommend on google developer docs. I think this page has full explanation.
This is something I’m interested in working on. I want to use a custom plugin from https://github.com/michaelx/jekyll-last-modified