-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate sitemap.xml for SEO indexing #1838
Open
ShubhamOulkar
wants to merge
5
commits into
expressjs:gh-pages
Choose a base branch
from
ShubhamOulkar:sitemap
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bjohansebas
reviewed
Mar 20, 2025
bjohansebas
reviewed
Mar 20, 2025
bjohansebas
reviewed
Mar 20, 2025
Should we consider adding urls for YouTube video and images used on website? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1762
how to test sitemap.xml?
test results from tool
Issue
The website contains inconsistent file formats in its changelog directory, resulting in incorrect alternate URLs generated in the sitemap.xml. Specifically, the following formats are observed:
ko/changelog/4x.md, tr/changelog/4x.md, uk/CHANGELOG.md
verify issue
When selecting Korean (ko) as the language on the changelog page, the website returns a "Page Not Found" error due to the presence of 4x.md, which seems to be an incorrect file format in this context.