Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate sitemap.xml for SEO indexing #1838

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

ShubhamOulkar
Copy link
Contributor

@ShubhamOulkar ShubhamOulkar commented Mar 19, 2025

closes #1762

how to test sitemap.xml?

  1. Visit hreflang tool
  2. Test url πŸ‘‰πŸ» https://deploy-preview-1838--expressjscom-preview.netlify.app/sitemap.xml

test results from tool

  1. Warning ⚠ Missing region independent link for Portuguese(pt), Chinese(zh)
  2. total 561 url's added in sitemap.xml with hreflang tags (17 languages).

Issue

The website contains inconsistent file formats in its changelog directory, resulting in incorrect alternate URLs generated in the sitemap.xml. Specifically, the following formats are observed: ko/changelog/4x.md, tr/changelog/4x.md, uk/CHANGELOG.md

verify issue

When selecting Korean (ko) as the language on the changelog page, the website returns a "Page Not Found" error due to the presence of 4x.md, which seems to be an incorrect file format in this context.

Note: Now I removed all changelog pages from sitemap and manually added only en/changelog/index.md to ensure SEO.

@ShubhamOulkar ShubhamOulkar requested review from a team as code owners March 19, 2025 13:14
Copy link

netlify bot commented Mar 19, 2025

βœ… Deploy Preview for expressjscom-preview ready!

Name Link
πŸ”¨ Latest commit f86e9a0
πŸ” Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67dcec3b14b154000885f55c
😎 Deploy Preview https://deploy-preview-1838--expressjscom-preview.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShubhamOulkar ShubhamOulkar marked this pull request as draft March 19, 2025 13:15
@ShubhamOulkar ShubhamOulkar changed the title test: sitemap WIP: sitemap Mar 19, 2025
@ShubhamOulkar ShubhamOulkar changed the title WIP: sitemap feat: generate sitemap.xml for SEO indexing Mar 19, 2025
@ShubhamOulkar ShubhamOulkar marked this pull request as ready for review March 19, 2025 14:24
@ShubhamOulkar
Copy link
Contributor Author

Should we consider adding urls for YouTube video and images used on website?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should generate a sitemap.xml
2 participants