Skip to content

Add missing test to CryptoSquareTest (54-character input) #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This repository contains the source for the exercises of the Java track on Exerc
Next to the exercises, the Java track also consists of the following tooling:

- [exercism/java-test-runner] - The Exercism [test runner][docs-test-runners] for the Java track that automatically verifies if a submitted solution passes all of the exercise's tests.
- [exercism/java-representer] - The Exercism [representer][docs-representers] for the Java track that creates normalized representations of submitted solutions.
- [exercism/java-representer]a - The Exercism [representer][docs-representers] for the Java track that creates normalized representations of submitted solutions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is accidental. Could you please revert this change?

- [exercism/java-analyzer] - The Exercism [analyzer][docs-analyzers] for the Java track that automatically provides comments on submitted solutions.

## Contributing Guide
Expand Down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the history for the problem specifications, it looks like we just need to rename the test method as the inputs, calls and expectations are still the same. Could you please update this change to just rename the test method (i.e. the diff should just show the fiftyFourCharacterPlaintextResultsInSevenChunksWithTrailingSpaces test method renamed to fiftyFourCharacterPlaintextResultsInEightChunksWithTrailingSpaces - the "Seven" is changed "Eight")?

Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,26 @@ public void eightCharacterPlaintextResultsInThreeChunksWithATrailingSpace() {

assertThat(cryptoSquare.getCiphertext()).isEqualTo(expectedOutput);
}
// Legacy test from older canonical-data.json – consider removing if outdated

@Disabled("Remove to run test")

/*@Disabled("Remove to run test")
@Test
public void fiftyFourCharacterPlaintextResultsInSevenChunksWithTrailingSpaces() {
CryptoSquare cryptoSquare = new CryptoSquare("If man was meant to stay on the ground, god would have " +
"given us roots.");
String expectedOutput = "imtgdvs fearwer mayoogo anouuio ntnnlvt wttddes aohghn sseoau ";

assertThat(cryptoSquare.getCiphertext()).isEqualTo(expectedOutput);
}
}*/
@Disabled("Remove to run test")
@Test
public void fiftyFourCharacterPlaintextResultsInEightChunksWithTrailingSpaces() {
CryptoSquare cryptoSquare = new CryptoSquare("If man was meant to stay on the ground, god would have " +
"given us roots.");
String expectedOutput = "imtgdvs fearwer mayoogo anouuio ntnnlvt wttddes aohghn sseoau ";

assertThat(cryptoSquare.getCiphertext()).isEqualTo(expectedOutput);
}

}