Add missing test to CryptoSquareTest (54-character input) #2965
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Thanks for helping to update the tests! I have some comments further below 👇🏻.
In addition to those, could you please also update the exercise's test.toml by running configlet sync -e crypto-square -u? When it asks if you want to replace an existing test case, just choose yes and it should update tests.toml for you.
To get configlet, run the bin/fetch-configlet script if you are on Linux or see configlet releases for Windows or MacOS.
| @@ -10,7 +10,7 @@ This repository contains the source for the exercises of the Java track on Exerc | |||
| Next to the exercises, the Java track also consists of the following tooling: | |||
|
|
|||
| - [exercism/java-test-runner] - The Exercism [test runner][docs-test-runners] for the Java track that automatically verifies if a submitted solution passes all of the exercise's tests. | |||
| - [exercism/java-representer] - The Exercism [representer][docs-representers] for the Java track that creates normalized representations of submitted solutions. | |||
| - [exercism/java-representer]a - The Exercism [representer][docs-representers] for the Java track that creates normalized representations of submitted solutions. | |||
There was a problem hiding this comment.
I think is accidental. Could you please revert this change?
There was a problem hiding this comment.
Looking at the history for the problem specifications, it looks like we just need to rename the test method as the inputs, calls and expectations are still the same. Could you please update this change to just rename the test method (i.e. the diff should just show the fiftyFourCharacterPlaintextResultsInSevenChunksWithTrailingSpaces test method renamed to fiftyFourCharacterPlaintextResultsInEightChunksWithTrailingSpaces - the "Seven" is changed "Eight")?
This PR adds a missing canonical test case for the 'crypto-square' exercise based on the uuid
33fd914e-fa44-445b-8f38-ff8fbc9fe6e6from problem-specifications. It verifies that a 54-character plaintext results in 8 chunks with trailing spaces.Reference: #2959
Notes for merge:
[no important files changed]