roman-numerals: add generator and regenerate tests#734
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
ErikSchierboom
force-pushed
the
roman-numerals-template
branch
from
adbeca9 to
5146d9f
Compare
ErikSchierboom
force-pushed
the
roman-numerals-template
branch
from
5146d9f to
a3d84c0
Compare
tasxatzial
left a comment
tasxatzial
left a comment
There was a problem hiding this comment.
- Extra line at the end of the tpl file.
- Unsynced .toml file
- .problem-specifications directory is included
tasxatzial
left a comment
tasxatzial
left a comment
There was a problem hiding this comment.
The tests file needs to be regenerated with the new names.
ErikSchierboom
force-pushed
the
roman-numerals-template
branch
3 times, most recently
from
bcc7feb to
f9f6e6f
Compare
|
Updated! |
[no important files changed]
ErikSchierboom
force-pushed
the
roman-numerals-template
branch
from
f9f6e6f to
6125bec
Compare
tasxatzial
left a comment
tasxatzial
left a comment
There was a problem hiding this comment.
In case you are wondering why I'm not merging after approval. I'll typically only merge trivial PRs, everything else I prefer to let the OP merge whenever they want.
|
Yes that is actually the etiquette most of exercism adheres to 👍 |
2 participants
Should be merged after #728 is merged