syncing roman-numerals to the problem specification#669
Closed
michalporeba wants to merge 2 commits into
Closed
Conversation
michalporeba
changed the title
tasxatzial
reviewed
Sep 11, 2024
tasxatzial
left a comment
tasxatzial
left a comment
Member
There was a problem hiding this comment.
The docs and metadata for all exercises were synced a few days ago, and there haven't been any changes to the problem descriptions since. It seems like your branch is out of sync, which could be causing the PR to show changes that don’t actually exist. Maybe do a git rebase main on your branch and then force-push?
michalporeba
force-pushed
the
sync-roman-numerals
branch
from
26542a6 to
eb16768
Compare
tasxatzial
requested changes
Sep 12, 2024
| (deftest three-thousand | ||
| (is (= "MMM" (roman-numerals/numerals 3000)))) | ||
|
|
||
| (deftest three-thousand |
Member
There was a problem hiding this comment.
Suggested change
| (deftest three-thousand | |
| (deftest three-thousand-one |
| (deftest three-thousand | ||
| (is (= "MMMI" (roman-numerals/numerals 3001)))) | ||
|
|
||
| (deftest three-thousand |
Member
There was a problem hiding this comment.
Suggested change
| (deftest three-thousand | |
| (deftest three-thousand-eight-hundred-eighty-eight |
| (deftest three-thousand | ||
| (is (= "MMMDCCCLXXXVIII" (roman-numerals/numerals 3888)))) | ||
|
|
||
| (deftest three-thousand |
Member
There was a problem hiding this comment.
Suggested change
| (deftest three-thousand | |
| (deftest three-thousand-nine-hundred-ninety-nine |
| @@ -55,3 +67,12 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
Suggested change
| (deftest one-thousand-six-hundred-sixty-six | |
| (is (= "MDCLXVI" (roman-numerals/numerals 1666)))) | |
Member
|
Closing this as it is superseded by #734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running sync on the roman numerals exercise to standardise the instructions and the test cases with the problem specification. Some of the test cases have changed so the solutions should be re-evaluated.