Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks in docker usage docs #15804

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

cameel
Copy link
Member

@cameel cameel commented Jan 31, 2025

Replaces #15780.

@cameel cameel self-assigned this Jan 31, 2025
@cameel cameel force-pushed the docker-docs-tweaks-and-redundant-example branch 2 times, most recently from 93e7e70 to a93b69e Compare January 31, 2025 18:35
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Feb 15, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Feb 15, 2025
@cameel cameel force-pushed the docker-docs-tweaks-and-redundant-example branch from 335ff75 to 19002a8 Compare February 18, 2025 15:07
@cameel
Copy link
Member Author

cameel commented Feb 18, 2025

@mehtavishwa30 I think you forgot to select rebase when using the option to update the branch. Note that this creates a merge commit instead of rebasing the branch.

I just pushed a properly rebased version. Please reapprove.

@cameel cameel requested a review from mehtavishwa30 February 18, 2025 15:08
@ethereum ethereum deleted a comment from github-actions bot Feb 18, 2025
@cameel cameel merged commit 053807e into develop Feb 18, 2025
74 checks passed
@cameel cameel deleted the docker-docs-tweaks-and-redundant-example branch February 18, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants