Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Example: Use a Specific Version Tag #15780

Closed
wants to merge 1 commit into from

Conversation

Bilogweb3
Copy link

It duplicates the ‘stable’ example, where it would be more appropriate to show an example using a specific version (0.8.23).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@nikola-matic
Copy link
Collaborator

This shouldn't be changed. There's a specific note just below your proposed changes that addressed this:

Specific compiler versions are supported as the Docker image tag such as `ethereum/solc:0.8.23`. We will be passing the
`stable` tag here instead of specific version tag to ensure that users get the latest version by default and avoid the issue of
an out-of-date version.

@cameel
Copy link
Member

cameel commented Jan 31, 2025

TBH the You can specify release build versions in the tag. For example: part does look rather redundant now that we removed hard-coded version from it. I wouldn't add back the version there as the PR tries to do but it would be fine to remove it and leave only the first example.

EDIT: I did that in #15804.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants