Skip to content

EOAs that delegate to a precompile #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2025
Merged

EOAs that delegate to a precompile #1191

merged 4 commits into from
Apr 19, 2025

Conversation

gurukamath
Copy link
Collaborator

What was wrong?

Currently, the EOA account that delegate to a precompile in 7702 are not handled properly. This PR also updates to 4.2.0 version of the EEST tests

How was it fixed?

Execute empty code when an EOA delegates to a pre-compile

@gurukamath gurukamath mentioned this pull request Apr 14, 2025
Closed
@danceratopz
Copy link
Member

There seems to be a problematic commit in forks/prague: 8f89be5

If I revert this commit, 7702-to-precompile fills all tests on EEST main a1c4eeff34.

@gurukamath
Copy link
Collaborator Author

There seems to be a problematic commit in forks/prague: 8f89be5

If I revert this commit, 7702-to-precompile fills all tests on EEST main a1c4eeff34.

The problem here seems to be the fact that all other t8n tools expect the variable accessList and eels-t8n expects accessLists. The state test fixtures also, provide accessLists.

So in the long run it might be good to align on one variable name. But in the short term, in the interest of avoiding changes to 5 different client t8n tools, eels-t8n can also start expecting accessList. I will push a commit with the hot fix in this PR and create an issue to track this in the long term.

@gurukamath gurukamath mentioned this pull request Apr 15, 2025
Open
@gurukamath
Copy link
Collaborator Author

Created #1194

@danceratopz
Copy link
Member

Thanks @gurukamath, this fills with EEST main a1c4eeff34!

This was referenced Apr 15, 2025
Merged
Merged
Closed
This was referenced Apr 15, 2025
Open
Merged
SamWilsn
SamWilsn reviewed Apr 16, 2025
View reviewed changes
@gurukamath
post review update-1
1bda60c 
change variable name from is_delegated to disable_precompiles
@marioevz marioevz mentioned this pull request Apr 16, 2025
Merged
8 tasks
SamWilsn
SamWilsn approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed tests pass, merge when ready.

@gurukamath gurukamath merged commit 4cf63ec into ethereum:forks/prague Apr 19, 2025
3 of 5 checks passed
SamWilsn pushed a commit that referenced this pull request May 15, 2025
@gurukamath @SamWilsn
EOAs that delegate to a precompile (#1191)
70a8810 
* delegated to a precompile

* update to eest 4.2.0

* expect variable accessList

* post review update-1

change variable name from is_delegated to disable_precompiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@petertdavies petertdavies Awaiting requested review from petertdavies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gurukamath @danceratopz @SamWilsn