chore(deps): bump execution-specs to v1.17.0 for fill and unit tests
#1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2025
Merged
marioevz
force-pushed
the
update-eels-forks-prague
branch
from
8aaf45b to
bf942c1
Compare
|
Note: We should "Rebase and merge" instead of the usual "Squash and merge" in order to preserve both commits and be able to |
3 tasks
danceratopz
reviewed
Apr 16, 2025
There was a problem hiding this comment.
Thanks for this, especially the test!
LGTM, holding off approval until ethereum/execution-specs#1191 is merged.
danceratopz
changed the title
forks/prague.forks/prague
spencer-tb
approved these changes
Apr 28, 2025
This was referenced May 7, 2025
danceratopz
changed the title
forks/praguev1.17.0 for fill and unit tests
danceratopz
approved these changes
May 19, 2025
There was a problem hiding this comment.
@marioevz, thanks for adding the PR. I took the liberty of bumping the version used here to the recent execution-specs release that includes Prague: https://github.com/ethereum/execution-specs/releases/tag/v1.17.0 - hope you don't mind.
| @@ -15,6 +15,7 @@ Test fixtures for use by clients are available for each release on the [Github r | |||
| - ✨ The `static_filler` plug-in now has support for static state tests (from [GeneralStateTests](https://github.com/ethereum/tests/tree/develop/src/GeneralStateTestsFiller)) ([#1362](https://github.com/ethereum/execution-spec-tests/pull/1362)). | |||
| - ✨ Introduce `pytest.mark.exception_test` to mark tests that contain an invalid transaction or block ([#1436](https://github.com/ethereum/execution-spec-tests/pull/1436)). | |||
| - 🐞 Fix `DeprecationWarning: Pickle, copy, and deepcopy support will be removed from itertools in Python 3.14.` by avoiding use `itertools` object in the spec `BaseTest` pydantic model ([#1414](https://github.com/ethereum/execution-spec-tests/pull/1414)). | |||
| - 🔀 Filling EELS branch updated to `forks/prague` ([#1454](https://github.com/ethereum/execution-spec-tests/pull/1454)). | |||
There was a problem hiding this comment.
Suggested change
| - 🔀 Filling EELS branch updated to `forks/prague` ([#1454](https://github.com/ethereum/execution-spec-tests/pull/1454)). | |
| - 🔀 Update EELS filling branch to [ethereum/[email protected]](https://github.com/ethereum/execution-specs/releases/tag/v1.17.0) ([#1454](https://github.com/ethereum/execution-spec-tests/pull/1454)). |
danceratopz
requested changes
May 19, 2025
There was a problem hiding this comment.
The EELS release doesn't fill Prague 😭
tests/prague/eip7702_set_code_tx/test_gas.py:822: in test_gas_cost
state_test(
src/pytest_plugins/filler/filler.py:750: in __init__
fixture = self.generate(
src/ethereum_test_specs/state.py:252: in generate
return self.make_state_test_fixture(t8n, fork, eips)
src/ethereum_test_specs/state.py:185: in make_state_test_fixture
transition_tool_output = t8n.evaluate(
src/ethereum_clis/transition_tool.py:536: in evaluate
return self._evaluate_server(
src/ethereum_clis/transition_tool.py:357: in _evaluate_server
output: TransitionToolOutput = TransitionToolOutput.model_validate(
E pydantic_core._pydantic_core.ValidationError: 1 validation error for TransitionToolOutput
E result.receipts
E Input should be a valid list [type=list_type, input_value={'transactionHash': '0x11...0000000000', 'logs': []}, input_type=dict]
E For further information visit https://errors.pydantic.dev/2.10/v/list_type
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Updates EELS to fill tests using
forks/praguebranch.Currently, some of the tests in main fail to fill because PR ethereum/execution-specs#1191 is required, and once merged, all tests should fill properly.
This PR also includes a workaround for this issue: ethereum/execution-specs#1194
The workaround should be removed once the issue is resolved.
🔗 Related Issues
None
✅ Checklist