-
Notifications
You must be signed in to change notification settings - Fork 173
chore(all): rename shadowed modules to enable ruff a005 #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for tackling this issue.
Just two small suggestions which could also help with the Opcodes
discussion we had earlier today.
cbbd2cd
to
74d7170
Compare
35b0f43
to
03e7a31
Compare
03e7a31
to
b60a389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @felix314159. The imports read much more clearly now.
I couldn't get to the bottom of the coverage flow fails (yet). The flow is failing when the filled fixtures (which get filled with evmone-t8n btw and gas-limit 45M) are ran against evmone-blocktest. I have not been able to reproduce this locally by building, filling with evmone and running the tests. It would need more investigation.
I filled all the modified tests on this branch and compared them to those generated on main via hasher. No changes, it is good.
Show full `fill` command.
uv run fill --until osaka tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py tests/benchmark/test_worst_bytecode.py tests/benchmark/test_worst_compute.py tests/benchmark/test_worst_memory.py tests/benchmark/test_worst_opcode.py tests/benchmark/test_worst_stateful_opcodes.py tests/berlin/eip2929_gas_cost_increases/test_precompile_warming.py tests/byzantium/eip198_modexp_precompile/test_modexp.py tests/cancun/eip1153_tstore/test_basic_tload.py tests/cancun/eip1153_tstore/test_tload_calls.py tests/cancun/eip1153_tstore/test_tload_reentrancy.py tests/cancun/eip1153_tstore/test_tstorage_clear_after_tx.py tests/cancun/eip1153_tstore/test_tstore_reentrancy.py tests/cancun/eip4788_beacon_root/test_beacon_root_contract.py tests/cancun/eip4844_blobs/test_point_evaluation_precompile.py tests/cancun/eip4844_blobs/test_point_evaluation_precompile_gas.py tests/cancun/eip6780_selfdestruct/test_dynamic_create2_selfdestruct_collision.py tests/cancun/eip6780_selfdestruct/test_reentrancy_selfdestruct_revert.py tests/cancun/eip6780_selfdestruct/test_selfdestruct.py tests/frontier/opcodes/test_all_opcodes.py tests/frontier/opcodes/test_call.py tests/frontier/opcodes/test_call_and_callcode_gas_calculation.py tests/frontier/opcodes/test_calldatacopy.py tests/frontier/opcodes/test_calldataload.py tests/frontier/opcodes/test_calldatasize.py tests/frontier/precompiles/test_precompiles.py tests/frontier/scenarios/test_scenarios.py tests/homestead/coverage/test_coverage.py tests/istanbul/eip1344_chainid/test_chainid.py tests/istanbul/eip152_blake2/test_blake2.py tests/osaka/eip7594_peerdas/test_get_blobs.py tests/osaka/eip7823_modexp_upper_bounds/test_modexp_upper_bounds.py tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py tests/osaka/eip7883_modexp_gas_increase/test_modexp_thresholds.py tests/osaka/eip7883_modexp_gas_increase/test_modexp_thresholds_transition.py tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py tests/paris/security/test_selfdestruct_balance_bug.py tests/shanghai/eip3651_warm_coinbase/test_warm_coinbase.py tests/shanghai/eip3855_push0/test_push0.py tests/shanghai/eip3860_initcode/test_initcode.py tests/shanghai/eip3860_initcode/test_with_eof.py tests/shanghai/eip4895_withdrawals/test_withdrawals.py --clean --output=fixtures-2133
I would like to understand the evmone coverage script fails, but they appear to be independent of this branch, see also this run which filled/ran tests:
https://github.com/ethereum/execution-spec-tests/actions/runs/17761869978/job/50476287251
This job is for your other PR @felix314159 #2152, let's continue to investigate there.
With parity on fixture hashes I think this is safe to merge now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was slightly too fast. @felix314159 could you just update these to address Mario's comments in his review.
Thx for the reviews, @danceratopz and mario! Can be merged now |
ποΈ Description
Title is self-explanatory, this PR allows us to (and does) enable checking for ruff a005
Relevant for #2128
Old name -> New name
pytest_plugins.logging.logging
->pytest_plugins.custom_logging.plugin_logging
code
->tools_code
types
->rpc_types
/cli_types
/exceptions_types
/execute_types
json
->base_types_json
src/ethereum_test_tools/vm/
-> [rip bozo]src/ethereum_test_vm/opcode.py
->src/ethereum_test_vm/opcodes.py
π Related Issues or PRs
N/A.
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.