Skip to content

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 15, 2025

πŸ—’οΈ Description

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@kclowes
Copy link
Collaborator Author

kclowes commented Sep 15, 2025

@danceratopz before I go further down this path, is this what we're aiming for to address ethereum/execution-specs#1402 ?

@kclowes kclowes force-pushed the chore/move-generic-names branch from 081936e to 5e6d0f2 Compare September 15, 2025 21:04
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting on this @kclowes. I think we should hold off with this and the other renamings until

is merged as it touches almost every source file and we'll have a lot of conflicts and a hard time rebasing.

If in the meantime you could take a holistic view to naming in ethereum-execution and see if it makes sense that would help. What I mean is, does the namespacing in the package make sense at all :) In particular:

  1. Wdyt about the path src/ethereum_spec_tests/ethereum_test_base_types as there's a lot of "ethereum" and "test" in those paths ))
  2. After this change we'll have ethereum_test_cli and ethereum_clis. Is this unambiguous enough?

I think it'd be helpful to do a build of ethereum-execution in EELS and check the namespacing as it currently is to see if it makes sense.

We should also keep this renaming in mind: #2133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants