-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new USB Serial JTAG reset strategy #779
base: main
Are you sure you want to change the base?
Conversation
4471afb
to
e20dfd9
Compare
Should I add a P4 here as well? |
47aacaf
to
e3544c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments that build on top of cleanups of #795
I think this still needs a fair bit of work, let me play around with it a bit tomorrow and I will try to give some more concrete feedback. |
Still not 100% happy with this, but I think it's in much better shape now at least. Remaining concerns are fairly minor, can be handled at another time (or just ignored 😁). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
This is mostly experimental, so opening as a draft.
I've been playing with (cc cc #691) and I was able to reproduce the issue with espflash AND esptool as well, following the same steps as mentioned here
I looked into esptool and specifically to this commit.
esptool
not using this fix as default for SERIAL_JTAG, it can be used manually with:--after reset_watchdog
The reasons (from esptool perspective) it's not on by default are: