Skip to content

Drop support for ESLint<8 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,11 @@ jobs:
node: 14
os: ubuntu-latest
# On old ESLint versions
- eslint: 7
node: 18
os: ubuntu-latest
- eslint: 6
node: 18
os: ubuntu-latest
- eslint: 5
node: 18
os: ubuntu-latest
- eslint: 4
- eslint: 8.0.0
node: 18
os: ubuntu-latest
# On the minimum supported ESLint/Node.js version
- eslint: 4
- eslint: 8.0.0
node: 14.18.0
os: ubuntu-latest

Expand All @@ -79,23 +70,11 @@ jobs:
- name: Uninstall Packages
run: |+
npm r -D vuepress eslint-plugin-eslint-plugin eslint-plugin-prettier vue-eslint-parser eslint-plugin-vue
- name: Install for ESLint v4
run: |+
npm i -D eslint-utils@2 --legacy-peer-deps
if: "matrix.eslint == 4"
- name: Install for ESLint v5
run: |+
npm i -D @typescript-eslint/parser@4 --legacy-peer-deps
if: "matrix.eslint == 5"
- name: Install ESLint ${{ matrix.eslint }}
run: |+
npm install -D eslint@${{ matrix.eslint }}
npx rimraf node_modules
- name: Install Packages
run: npm install
if: "matrix.eslint != 4"
- name: Install Packages --legacy-peer-deps
run: npm install --legacy-peer-deps
if: "matrix.eslint == 4"
- name: Test
run: npm run -s test:mocha
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ npm install --save-dev eslint eslint-plugin-es-x

::: tip Requirements
- Node.js `14.18.0` or newer, except `15.x`.
- ESLint `4.19.1` or newer.
- ESLint `8.x` or newer.
:::

## 📖 Usage
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lib"
],
"peerDependencies": {
"eslint": ">=4.19.1"
"eslint": ">=8"
},
"dependencies": {
"eslint-utils": "^2.0.0 || ^3.0.0",
Expand Down