Skip to content

Drop support for ESLint<8 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Drop support for ESLint<8 #43

merged 2 commits into from
Jan 21, 2023

Conversation

ota-meshi
Copy link
Member

close #38

@ota-meshi ota-meshi marked this pull request as ready for review January 20, 2023 09:36
@ota-meshi ota-meshi requested a review from a team January 20, 2023 09:42
@voxpelli
Copy link
Member

Any reason to keep supporting anything older than ESLint 8?

@ota-meshi
Copy link
Member Author

Thank you for your comment.

I don't know if it makes sense for you, but I often refer to typescript-eslint to decide which version of eslint to support.
https://github.com/typescript-eslint/typescript-eslint/blob/503bfde75c66d9fb6a36dc1a94de6e47bdb5376d/packages/eslint-plugin/package.json#L74
Because I often use typescript-eslint related modules in test cases.

If we support eslint v6 or later, we don't need the if: branch on CI.

@voxpelli
Copy link
Member

I would opt for bumping to the newest ESLint version, then the need to bump it again and do a new major will be very low for that reason for a considerable amount of time, and ESLint 8 has been out long enough that there should be little point in supporting older versions of ESLint?

@ota-meshi ota-meshi changed the title Drop support for ESLint<6 Drop support for ESLint<8 Jan 21, 2023
@ota-meshi
Copy link
Member Author

I have updated this PR to change the minimum version of eslint that the plugin supports to v8.

@ota-meshi ota-meshi merged commit 61d47aa into master Jan 21, 2023
@ota-meshi ota-meshi deleted the drop-old-eslint branch January 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for ESLint<v6
2 participants