Skip to content

fix(discojs): keep one aggregation round per payload exchange #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ale18V merged 1 commit into from
Oct 6, 2026
Merged

fix(discojs): keep one aggregation round per payload exchange #1248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions discojs/src/client/decentralized/decentralized_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,9 @@ export class DecentralizedClient extends Client<"decentralized"> {
if (connections === undefined)
throw new Error("peer's connections is undefined");
// Generate our payloads for this communication round and send them to all ready connected peers
// Aggregation may complete while payloads are being encoded and sent, so
// every contribution in this exchange must retain the same round number.
const aggregationRound = this.aggregator.round;
const payloads = this.aggregator.makePayloads(result);
await Promise.all(
payloads
Expand All @@ -496,7 +499,7 @@ export class DecentralizedClient extends Client<"decentralized"> {
this.aggregator.add(
this.ownId,
payload,
this.aggregator.round,
aggregationRound,
communicationRound,
);
return;
Expand All @@ -510,7 +513,7 @@ export class DecentralizedClient extends Client<"decentralized"> {
const msg: messages.PeerMessage = {
type: MType.Payload,
peer: id,
aggregationRound: this.aggregator.round,
aggregationRound,
communicationRound,
payload: encoded,
};
Expand All @@ -520,7 +523,7 @@ export class DecentralizedClient extends Client<"decentralized"> {
debug(
`[${shortenId(this.ownId)}] send weight update to peer ${shortenId(msg.peer)}` +
` for round (%d, %d)`,
this.aggregator.round,
aggregationRound,
communicationRound,
);
})
Expand Down
Loading