Repository navigation
fix(discojs): keep one aggregation round per payload exchange - #1248
Merged
Merged
Conversation
JulienVig
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Resolves #1247. Fixes a race condition in
DecentralizedClientwhere outgoing peer payload messages could be stamped with a subsequent aggregation round. During asynchronous payload encoding, incoming contributions from other peers could advancethis.aggregator.roundbeforePeerMessageconstruction, causing outgoing payloads to carry an advanced round number and leaving recipient peers hanging indefinitely.Technical plan
Snapshot
this.aggregator.roundinto a localaggregationRoundconstant at the start of each communication round inonRoundEndCommunication. Use this captured value consistently when adding the local contribution, constructing outgoing peer messages, and logging debug messages.Deviations from plan
None.
Todo
None.