Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4145 - implement popup versions of ketcher and routing #6455

Conversation

tanas80
Copy link
Collaborator

@tanas80 tanas80 commented Feb 9, 2025

How the feature works? / How did you fix the issue?

Fix example serve adding serve.json for popup, iframe, duo URLs.

Fix #4145

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Fix example serve adding serve.json for popup and iframe urls.
Fix dependencies updating.
@NataliaLoginova NataliaLoginova merged commit e974a52 into release/3.1 Feb 10, 2025
8 checks passed
@NataliaLoginova NataliaLoginova deleted the 4145-implement-popup-versions-of-ketcher-and-routing-from-3.1 branch February 10, 2025 10:10
@tanas80 tanas80 linked an issue Feb 11, 2025 that may be closed by this pull request
3 tasks
tanas80 added a commit that referenced this pull request Feb 11, 2025
rrodionov91 pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1 day] Implement popup versions of ketcher (and routing)
2 participants