Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1 day] Implement popup versions of ketcher (and routing) #4145

Closed
3 tasks
AlexeyGirin opened this issue Feb 23, 2024 · 1 comment · Fixed by #6474, #6455, #6477 or #6480
Closed
3 tasks

[1 day] Implement popup versions of ketcher (and routing) #4145

AlexeyGirin opened this issue Feb 23, 2024 · 1 comment · Fixed by #6474, #6455, #6477 or #6480
Assignees
@tanas80
Labels
Autotests Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 3.2.0-rc....

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Feb 23, 2024 •
edited
Loading

  • Make a separate version of Ketcher for autotests (adopt existed Example) - full screen (we have it already) and popup ketcher
  • Make site routing in 2 options - "full window" ketcher, popup ketcher
  • Provide test page with few instances of Ketcher on the same page

Popup ketcher should be available using link '/KetcherDemoSA/index.html?mode=react-mui-material-dialog-857x648';
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.19.0-rc.2 milestone Feb 23, 2024
@Zhirnoff Zhirnoff changed the title Project related changes needed for autotesting Configure autotests to run embedded Ketcher or pop-up window environment Mar 6, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label May 7, 2024
@AlexeyGirin
Copy link
Collaborator Author

No test cases needed for that particular case

@AlexeyGirin AlexeyGirin mentioned this issue Jul 4, 2024
Closed
@AlexeyGirin AlexeyGirin assigned tanas80 and unassigned rrodionov91 Jan 24, 2025
@AlexeyGirin AlexeyGirin changed the title Configure autotests to run embedded Ketcher or pop-up window environment Implement popup versions of ketcher Jan 24, 2025
@AlexeyGirin AlexeyGirin changed the title Implement popup versions of ketcher Implement popup versions of ketcher (and routing) Jan 24, 2025
@AlexeyGirin AlexeyGirin changed the title Implement popup versions of ketcher (and routing) [1 Day] Implement popup versions of ketcher (and routing) Jan 29, 2025
@AlexeyGirin AlexeyGirin changed the title [1 Day] Implement popup versions of ketcher (and routing) [1 day] Implement popup versions of ketcher (and routing) Jan 29, 2025
@tanas80 tanas80 mentioned this issue Jan 31, 2025
Closed
9 tasks
@rrodionov91 rrodionov91 linked a pull request Feb 2, 2025 that will close this issue
#4145 - implement popup versions of ketcher and routing #6403
Closed
9 tasks
@tanas80 tanas80 mentioned this issue Feb 9, 2025
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Feb 10, 2025
@tanas80
#4145 - implement popup versions of ketcher and routing (#6455)
e974a52 
* Fix example adding duo.
Fix example serve adding serve.json for popup and iframe urls.
Fix dependencies updating.

* Cleanup comments.
@tanas80 tanas80 mentioned this issue Feb 11, 2025
Merged
9 tasks
@tanas80 tanas80 linked a pull request Feb 11, 2025 that will close this issue
#4145 - implement popup versions of ketcher and routing #6455
Merged
9 tasks
tanas80 added a commit that referenced this issue Feb 11, 2025
@tanas80
Revert "#4145 - implement popup versions of ketcher and routing (#6455)"
d85eece 
This reverts commit e974a52.
@tanas80 tanas80 mentioned this issue Feb 11, 2025
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Feb 11, 2025
@tanas80
Revert "#4145 - implement popup versions of ketcher and routing (#6455)…
8431839 
…" (#6477)

This reverts commit e974a52.
@rrodionov91 rrodionov91 linked a pull request Feb 11, 2025 that will close this issue
Revert: #4145 - implement popup versions of ketcher and routing (revert #6455) #6477
Merged
9 tasks
@tanas80 tanas80 mentioned this issue Feb 11, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanas80 tanas80

Labels
Autotests Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 3.2.0-rc.1 (Current)
4 participants
@tanas80 @rrodionov91 @AlexeyGirin @Zhirnoff