#4145 - implement popup versions of ketcher and routing from master #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dependencies updating.
auto-assign
bot
requested review from
AlexeyGirin,
NataliaLoginova and
rrodionov91
NataliaLoginova
approved these changes
Feb 11, 2025
NataliaLoginova
deleted the
4145-implement-popup-versions-of-ketcher-and-routing-from-master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix example serve adding serve.json for popup and iframe urls.
Now npm run serve:standalone executes web server 'serve', which is listening on port 4002 and serving urls:
http://localhost:4002/popup - from the patch
http://localhost:4002/iframe - found in the code
http://localhost:4002/duo - two Editor instances on the same page (two react components, not iframe).
http://localhost:4002/* - as previous
Fix #4145
Check list
#1234 – issue name