Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start to add some (manual) compatibility tests #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions compatibility-tests/install-ses.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@

// alas '-r esm' vs (native) ESM means we can't import real modules if we
// start with '-r esm', so import the built distfile. Don't forget to rebuild
// this file (cd packages/ses && yarn build) after any changes to the SES
// source files.
//import { lockdown } from '../packages/ses/src/main.js';
import { lockdown } from '../packages/ses/dist/ses.cjs';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #315, this usage pattern changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean #307, right?

I'll update the imports after that PR lands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warner It landed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes, #307 was the correct globalThis change!


lockdown();
// We are now in the "Start Compartment". Our global has all the same
// powerful things it had before, but the primordials have changed to make
// them safe to use in the arguments of API calls we make into more limited
// compartments. 'Compartment' and 'harden' are now present in our global
// scope.
Comment on lines +13 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment. Compartment and harden will now already be present.

1 change: 1 addition & 0 deletions compatibility-tests/tape-4/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
yarn.lock
13 changes: 13 additions & 0 deletions compatibility-tests/tape-4/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"name": "tape-4-compat",
"private": true,
"version": "0",
"scripts": {
"test": "node -r esm test.js"
},
"dependencies": {
"tape": "4.13.2"
},
"devDependencies": {
}
}
12 changes: 12 additions & 0 deletions compatibility-tests/tape-4/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import '../install-ses.js';
import { test } from 'tape';

function parse() {
throw TypeError('Error parsing');
}

test('parse', t => {
t.ok(true);
t.throws(parse, /Error parsing/, 'expected failure');
t.end();
});
1 change: 1 addition & 0 deletions compatibility-tests/tape-5/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
yarn.lock
13 changes: 13 additions & 0 deletions compatibility-tests/tape-5/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"name": "tape-5-compat",
"private": true,
"version": "0",
"scripts": {
"test": "node -r esm test.js"
},
"dependencies": {
"tape": "5.0.0"
},
"devDependencies": {
}
}
12 changes: 12 additions & 0 deletions compatibility-tests/tape-5/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import '../install-ses.js';
import { test } from 'tape';

function parse() {
throw TypeError('Error parsing');
}

test('parse', t => {
t.ok(true);
t.throws(parse, /Error parsing/, 'expected failure');
t.end();
});