-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start to add some (manual) compatibility tests #311
base: master
Are you sure you want to change the base?
Conversation
31a9fa3
to
02ed554
Compare
// this file (cd packages/ses && yarn build) after any changes to the SES | ||
// source files. | ||
//import { lockdown } from '../packages/ses/src/main.js'; | ||
import { lockdown } from '../packages/ses/dist/ses.cjs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #315, this usage pattern changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean #307, right?
I'll update the imports after that PR lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@warner It landed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes, #307 was the correct globalThis
change!
// compartments. 'Compartment' and 'harden' are now present in our global | ||
// scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale comment. Compartment
and harden
will now already be present.
@warner is this obsolete? Can it be closed? |
These must be run manually for now:
cd compatibility-tests/tape-4 && yarn && yarn test
, after building the main SES dist bundle.They do not pass yet.