start to add some (manual) compatibility tests #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
compatibility-tests
branch
from
31a9fa3 to
02ed554
Compare
kriskowal
reviewed
May 15, 2020
| // this file (cd packages/ses && yarn build) after any changes to the SES | ||
| // source files. | ||
| //import { lockdown } from '../packages/ses/src/main.js'; | ||
| import { lockdown } from '../packages/ses/dist/ses.cjs'; |
erights
reviewed
May 23, 2020
Comment on lines
+13
to
+14
| // compartments. 'Compartment' and 'harden' are now present in our global | ||
| // scope. |
There was a problem hiding this comment.
Stale comment. Compartment and harden will now already be present.
|
@warner is this obsolete? Can it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These must be run manually for now:
cd compatibility-tests/tape-4 && yarn && yarn test, after building the main SES dist bundle.They do not pass yet.