Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start to add some (manual) compatibility tests #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

warner
Copy link
Contributor

@warner warner commented May 15, 2020

These must be run manually for now: cd compatibility-tests/tape-4 && yarn && yarn test, after building the main SES dist bundle.

They do not pass yet.

@warner warner marked this pull request as ready for review May 15, 2020 20:14
@warner warner requested a review from kriskowal May 15, 2020 20:14
@warner warner force-pushed the compatibility-tests branch from 31a9fa3 to 02ed554 Compare May 15, 2020 21:39
// this file (cd packages/ses && yarn build) after any changes to the SES
// source files.
//import { lockdown } from '../packages/ses/src/main.js';
import { lockdown } from '../packages/ses/dist/ses.cjs';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #315, this usage pattern changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean #307, right?

I'll update the imports after that PR lands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warner It landed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes, #307 was the correct globalThis change!

Comment on lines +13 to +14
// compartments. 'Compartment' and 'harden' are now present in our global
// scope.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment. Compartment and harden will now already be present.

@erights
Copy link
Contributor

erights commented Feb 28, 2021

@warner is this obsolete? Can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants