Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundle-source): assert that the entrypoint exists at all #1256

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(bundle-source): assert that the entrypoint exists at all #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/bundle-source/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ export default async function bundleSource(
options = {},
powers = undefined,
) {
assert(fs.existsSync(startFilename));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un-requested feedback: I still would prefer avoiding Sync APIs where possible. In this case stat and checking for an ENOENT error is the alternative

if (typeof options === 'string') {
options = { format: options };
}
Expand Down
9 changes: 9 additions & 0 deletions packages/bundle-source/test/test-missing-entrypoint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { lockdown } from '@endo/lockdown';

import test from 'ava';
import bundleSource from '../src/index.js';

test(`missing entrypoint`, async t => {
await t.throwsAsync(() => bundleSource('___missing.js', 'endoZipBase64'),
{ message: 'xxx' });
});