-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bundle-source): assert that the entrypoint exists at all #1256
base: master
Are you sure you want to change the base?
Conversation
@kriskowal this is "draft" because the patch is insufficient in at least the following ways:
but I'm hoping you might be able to point me in the right direction so I can make it better. What's the right sort of way to build the assertion? Would it be easier to build in (incidentally, patching my agoric-sdk copy with this code was enough to help figure out where I had a typo in my |
@@ -402,6 +402,7 @@ export default async function bundleSource( | |||
options = {}, | |||
powers = undefined, | |||
) { | |||
assert(fs.existsSync(startFilename)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
un-requested feedback: I still would prefer avoiding Sync
APIs where possible. In this case stat
and checking for an ENOENT
error is the alternative
I’m sure there’s a more correct way to ensure that the file exists within compartment-mapper. The mystery is how it’s possible for |
closes #1206