Skip to content

Add chunk_size to iter_lines to be compat with requests #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HiromuHota wants to merge 1 commit into from
Closed

Add chunk_size to iter_lines to be compat with requests #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions httpx/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,10 +923,10 @@ def iter_text(self, chunk_size: int | None = None) -> typing.Iterator[str]:
for chunk in chunker.flush():
yield chunk

def iter_lines(self) -> typing.Iterator[str]:
def iter_lines(self, chunk_size: int | None = None) -> typing.Iterator[str]:
decoder = LineDecoder()
with request_context(request=self._request):
for text in self.iter_text():
for text in self.iter_text(chunk_size=chunk_size):
for line in decoder.decode(text):
yield line
for line in decoder.flush():
Expand Down