Add chunk_size to iter_lines to be compat with requests #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

HiromuHota wants to merge 1 commit into encode:master from snorkel-ai:hh/add_chunk_size

HiromuHota commented Aug 26, 2025 •

edited

Loading

Summary

This PR adds chunk_size to iter_lines to be compat with requests.

Checklist

I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.


          Add chunk_size to iter_lines to be compat with requests

20b4db9

Author

HiromuHota commented Aug 26, 2025

Closing as adding chunk_size itself doesn't make it compat with requests.Response, which has decode_unicode and delimiter.
https://requests.readthedocs.io/en/latest/api/#requests.Response.iter_lines

HiromuHota closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet