-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cmake build without automake #250
Conversation
@1whatleytay great PR!. It's sad that this PR is not being considered (yet). Even though I applied your changes to my newly created fork and encounter a problem:
The errors weren't saying much, but after some time I found the typo in one of the files - problematic line. There is a missing D int the option. So it should be like this - In addition, #258 includes a crucial cmake typo. I suggest you include it to your changes to minimize the number of PRs. After that I noticed the missing compile option when set(LIB_COMPILE_DEFINITIONS
${LIB_COMPILE_DEFINITIONS}
-DHAVE_SYS_INOTIFY_H) Hope it gets merged! |
Hi @1whatleytay, I'd really like to get this merged. Unfortunately, I'm not maintaining the CMake build system. I lack the expertise, and I've decided to move the CMake stuff on a separate branch, in case somebody with the required expertise can have a look at it. It seems you've done a great job here. If you're feeling like having a look at this, feel free, and I'll gladly integrate the CMake support back into |
I want to use this as a library by including it via cmake as a git submodule! I can't right now because of how fswatch configures stuff with cmake :(
I wrote something here as to why a cmake build system would be helpful. I'd appeciate any feedback!