Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcpkg support (Windows package manager) #251

Open
YenForYang opened this issue Aug 11, 2020 · 2 comments · May be fixed by #282
Open

Vcpkg support (Windows package manager) #251

YenForYang opened this issue Aug 11, 2020 · 2 comments · May be fixed by #282

Comments

@YenForYang
Copy link

Hi, I was wondering if vcpkg integration could be fixed. Someone posted the issue more than a year ago in vcpkg's repo around a year ago: microsoft/vcpkg#5843.

According to the post, the problems preventing inclusion are:

  • libfswatch_config.h are not found in source.
  • This port only supports Linux.
  • Without build documentation.
  • Some macro such as PACKAGE_STRING PACKAGE_NAME PACKAGE_BUGREPORT PACKAGE PACKAGE_URL are not found.
  • It seems like that the port has code bug in source. eg: optarg and getopt not found.

There is currently a pull request on fixing CMAKE, but I haven't looked into it: #250 (comment)

Related: #176.

Thanks.

@birbilis
Copy link

why not use MSYS2 with MINGW-W64 (that one also supports 32-bit btw, the name just implies it's an evolution of the old MINGW) with GNU tooling instead of having to fix CMAKE for building on Windows?

@emcrisostomo
Copy link
Owner

The only requirement I ask on a PR that supports CMake is that

  • It builds correctly and with the same behaviour on all the currently supported operating systems (not just, let's say, Windows)
  • it does not break the Autotools build.

For this reason #250 has been closed.

There's a newer PR (#282) which is quite elaborated, but it has the same problems, and I've asked the author whether he's willing to help converge to a situation in which the previously mentioned requirements are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants