Skip to content

feat: create Runs TES component #156

Merged
JaeAeich merged 30 commits intomainfrom
tes/lit
Nov 16, 2023
Merged

feat: create Runs TES component #156
JaeAeich merged 30 commits intomainfrom
tes/lit

Conversation

@JaeAeich
Copy link
Contributor

@JaeAeich JaeAeich commented Nov 6, 2023

Description

Create TES create runs comp using design package
Fixes #155

Checklist

  • My code follows the contributing guidelines of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have not reduced the existing code coverage.

Comments

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2023

⚠️ No Changeset found

Latest commit: 65b6f24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloud-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 6:23pm

@anuragxxd
Copy link
Member

Hey @JaeAeich can you add the docs here in too & maybe close this pr #146. It will help keep tes thing in one place & we can merge this after #157 & then this #149 (comment)

@JaeAeich
Copy link
Contributor Author

JaeAeich commented Nov 8, 2023

@git-anurag-hub can you please check this PR out, I have a couple of issues here:

  • For some reason I can't set @property or @state in this eslint throws error.
  • I am using any for almost everything which defeats the purpose of typescript and eslint shows alot of warnings.

Could you please help me on how should I proceed from here.

@JaeAeich
Copy link
Contributor Author

  • Even if a user adds input, output, volume, resources or additional executor fields and does not (or only partly) fills them out, the client shouldn't pass empty strings, but rather omit the empty string values from the request. The only exception is that all required fields for a given section MUST be filled in, or the user should otherwise delete the section.

Hey @git-anurag-hub leaving this here just to discuss as I don;t think we can have an abstraction of this at design level, if so we need to see what would be the best way to handle it package side.

@JaeAeich
Copy link
Contributor Author

I have pushed the fix for the being able to del, required fields. The false thing should be fixed by #171 👍

@JaeAeich
Copy link
Contributor Author

Hey @uniqueg I have patched some of the concerns which could be scoped in this PR. Please take a look.

Component creates task runs fine mostly but for some fields it request malforms, I believe it to be a backend issue.

@git-anurag-hub Please review it, I have added types for and tried to minimize use of any. Let me know if there are changes.

@uniqueg
Copy link
Member

uniqueg commented Nov 15, 2023

Looks very nice, thanks a lot @JaeAeich 🙏

anuragxxd
anuragxxd previously approved these changes Nov 15, 2023
Copy link
Member

@anuragxxd anuragxxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just some comments!

Copy link
Member

@anuragxxd anuragxxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work as always :)

anuragxxd
anuragxxd previously approved these changes Nov 15, 2023
@JaeAeich JaeAeich merged commit f0bcd71 into main Nov 16, 2023
@JaeAeich JaeAeich deleted the tes/lit branch November 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Runs TES component

3 participants