Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @JaeAeich can you add the docs here in too & maybe close this pr #146. It will help keep tes thing in one place & we can merge this after #157 & then this #149 (comment) |
|
@git-anurag-hub can you please check this PR out, I have a couple of issues here:
Could you please help me on how should I proceed from here. |
Hey @git-anurag-hub leaving this here just to discuss as I don;t think we can have an abstraction of this at design level, if so we need to see what would be the best way to handle it package side. |
|
I have pushed the fix for the being able to del, required fields. The false thing should be fixed by #171 👍 |
|
Hey @uniqueg I have patched some of the concerns which could be scoped in this PR. Please take a look.
@git-anurag-hub Please review it, I have added types for and tried to minimize use of |
|
Looks very nice, thanks a lot @JaeAeich 🙏 |
anuragxxd
left a comment
There was a problem hiding this comment.
Looks good to me! Just some comments!
packages/ecc-client-lit-ga4gh-tes/src/components/tes-create-run/tes-create-run.ts
Show resolved
Hide resolved
anuragxxd
left a comment
There was a problem hiding this comment.
Looks good to me! Great work as always :)
Description
Create TES create runs comp using design package
Fixes #155
Checklist
Comments